-
-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support passing extra args to pip install #655
base: master
Are you sure you want to change the base?
Conversation
This PR has been automatically marked as stale because it has been open 30 days |
Please review 🙏 |
This is a needed improvement, please review |
please review 🙏 |
This PR has been automatically marked as stale because it has been open 30 days |
@antonbabenko please review 🙏 |
Description
Added support to pass extra arguments to pip install command
Motivation and Context
Due to limitations with our CI, we can't use docker when installing and zipping requirements.
To overcome this we use the
platform
flag when running pip install to download the right distribution per lambda architecture.Breaking Changes
No
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectsI have tested these changes locally and deployed a lambda to AWS. I am happy to do additional testing if necessary.
pre-commit run -a
on my pull request